Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9753 )
Change subject: KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9753/2/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/9753/2/src/kudu/client/meta_cache.h@450 PS2, Line 450: bool is_exact_lookup, Could you convert this (and the instance in LookupRpc) into an enum class? Hopefully that'll improve the descriptivity of the argument. http://gerrit.cloudera.org:8080/#/c/9753/2/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/9753/2/src/kudu/client/meta_cache.cc@1090 PS2, Line 1090: rpc->SendRpc(); Why isn't this SendRpcSlowPath? Or conversely, why doesn't LookupTabletByKey call SendRpc? Could the two methods be unified with the help of an enum to control the "OrNext" behavior? -- To view, visit http://gerrit.cloudera.org:8080/9753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f17ffa88289c766b5b168b22da9781bf78f5592 Gerrit-Change-Number: 9753 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 18:51:41 +0000 Gerrit-HasComments: Yes
