Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9753 )
Change subject: KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9753/2/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/9753/2/src/kudu/client/meta_cache.cc@656 PS2, Line 656: VLOG(4) << "Fast lookup: no cache entry for " << ToString() > Might make more sense to keep this as part of SendRpc. hmm, then I have to duplicate it into 'LookupTabletByKey' and 'LookupTabletByKeyOrNext' as well, right? I could move it to the 'DoFastPathLookup' function but then I can't get the full ToString() of the LookupRpc. What do you think its best? Maybe just reword this statement to not say 'Fast lookup'? -- To view, visit http://gerrit.cloudera.org:8080/9753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f17ffa88289c766b5b168b22da9781bf78f5592 Gerrit-Change-Number: 9753 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 16:31:05 +0000 Gerrit-HasComments: Yes
