Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9753 )
Change subject: KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9753/3/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/9753/3/src/kudu/client/meta_cache.h@380 PS3, Line 380: kPoint, > Nit: don't we use ALL_CAPS for enum (and enum class) entries? the style guide allows for either all caps or kFoo and currently prefers kFoo (https://google.github.io/styleguide/cppguide.html#Enumerator_Names) http://gerrit.cloudera.org:8080/#/c/9753/3/src/kudu/client/meta_cache.h@384 PS3, Line 384: kRange > Nit: kPoint makes sense, but kRange could be a little more precise, since t how about kLowerBound? -- To view, visit http://gerrit.cloudera.org:8080/9753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f17ffa88289c766b5b168b22da9781bf78f5592 Gerrit-Change-Number: 9753 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 29 Mar 2018 16:43:26 +0000 Gerrit-HasComments: Yes
