Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 )
Change subject: KUDU-2351 Add IP/port for Recv() failure ...................................................................... Patch Set 6: (3 comments) > Patch Set 6: > > (3 comments) > > You may also want to make these changes to the TlsSocket class in > tls_socket.cc, which is used instead of the normal socket for encrypted RPCs. http://gerrit.cloudera.org:8080/#/c/9818/6/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/9818/6/src/kudu/util/net/socket-test.cc@46 PS6, Line 46: virtual void SetUp() OVERRIDE > prefer using the C++11 style for new code here and below: Done http://gerrit.cloudera.org:8080/#/c/9818/6/src/kudu/util/net/socket-test.cc@48 PS6, Line 48: address.ParseString("127.0.0.1", 11010); > Is this address being used anywhere? If possible avoid hard coded ports, s address is used to check the error message, + I need to bind to something. This port number was used in ksck_remote-test.cc: // Hard-coded ports for the masters. This is safe, as these tests run under // a resource lock (see CMakeLists.txt in this directory). // TODO we should have a generic method to obtain n free ports. opts.master_rpc_ports = { 11010, 11011, 11012 }; On the other hand I didn't set up the resource lock here, so it's still valid. How should I resolve this? http://gerrit.cloudera.org:8080/#/c/9818/6/src/kudu/util/net/socket-test.cc@95 PS6, Line 95: TEST_F(SocketTest, TestRecvReset) { > gtest has a built-in feature that facilitates writing this style of test, c I looked into it but I'm not sure if this is what I should use here as I need two completely different code paths with completely different error messages, I just use the same method for convenience, but they're distinct test cases. -- To view, visit http://gerrit.cloudera.org:8080/9818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22436b13bb351b132e1c0b7159294dd0c980c2b3 Gerrit-Change-Number: 9818 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 19:56:25 +0000 Gerrit-HasComments: Yes
