Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9818 )

Change subject: KUDU-2351 Add IP/port for Recv() failure
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9818/10/src/kudu/util/net/socket-test.cc
File src/kudu/util/net/socket-test.cc:

http://gerrit.cloudera.org:8080/#/c/9818/10/src/kudu/util/net/socket-test.cc@98
PS10, Line 98: TEST_F(SocketTest, TestRecvReset) {
             :   DoTest(false, "recv error from 127.0.0.1:[0-9]+: Resource 
temporarily unavailable");
             : }
I'm not 100% sure what this test is meant to test. It seems this is testing a 
timeout case, not a connection disconnection case -- the listening socket is 
sleeping 200ms before closing, but the connecting socket has a recv timeout of 
100ms, so it's getting EAGAIN which just means a timeout. That stringifies to 
"Resource temporarily unavailable".

What is the case we're attempting to test here?



--
To view, visit http://gerrit.cloudera.org:8080/9818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22436b13bb351b132e1c0b7159294dd0c980c2b3
Gerrit-Change-Number: 9818
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <abu...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Wed, 04 Apr 2018 19:39:02 +0000
Gerrit-HasComments: Yes

Reply via email to