Attila Bukor has posted comments on this change. ( )

Change subject: KUDU-2351 Add IP/port for Recv() failure

Patch Set 10:

File src/kudu/util/net/
PS9, Line 1: // Licensed to the Apache Software Foundation (ASF) under one
> nit: blank line at top of file
PS9, Line 45:   virtual void TearDown() override {
> style: indentation seems off in this file. we only indent private/public by
PS9, Line 46:     for (auto& thread : threads) {
            :       thread.join();
            :     }
> is this necessary?
you're right, I forgot deleting it after refactoring
PS9, Line 56:
> again strange indent
PS9, Line 63: CHECK_OK(lis
> hrm, we don't really use std::promise and std::future elsewhere in the code
ok, changing it. would it make sense to rewrite Promise in util/promise.h to be 
a wrapper around std::future for now? I mean in a separate refactor commit of 
PS9, Line 73: istener_.Accept(
> should CHECK_OK this
PS9, Line 76:  SleepFor(MonoDelta::FromMilliseconds(200));
            :         CHECK_OK(lis
> these aren't needed in this scope - they can be inside 'if (accept)'
Done, also stayed there also refactoring...
PS9, Line 80:
> also CHECK_OK
PS9, Line 93: UE(s.IsNetwork
> here too

To view, visit
To unsubscribe, visit

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22436b13bb351b132e1c0b7159294dd0c980c2b3
Gerrit-Change-Number: 9818
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <>
Gerrit-Reviewer: Attila Bukor <>
Gerrit-Reviewer: Dan Burkert <>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-Comment-Date: Wed, 04 Apr 2018 11:37:26 +0000
Gerrit-HasComments: Yes

Reply via email to