Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 )
Change subject: KUDU-2384. Don't collect thread stacks when running under debugger ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9835/1/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9835/1/src/kudu/util/debug-util.cc@728 PS1, Line 728: if (IsBeingDebugged()) { Why do this here and not inside StackTraceCollector::TriggerAsync? Between KernelStackWatchdog and SnapshotAllStacks I think you've covered all of the entry points into TriggerAsync, but that can change in the future; better to future-proof it by checking as deeply as possible, no? http://gerrit.cloudera.org:8080/#/c/9835/1/src/kudu/util/os-util.cc File src/kudu/util/os-util.cc: http://gerrit.cloudera.org:8080/#/c/9835/1/src/kudu/util/os-util.cc@166 PS1, Line 166: = -1 Nit: this initialization is unnecessary, right? -- To view, visit http://gerrit.cloudera.org:8080/9835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib17ffb9514e9b440b8d97843374d2a60913a398b Gerrit-Change-Number: 9835 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 28 Mar 2018 00:25:22 +0000 Gerrit-HasComments: Yes
