Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 )
Change subject: KUDU-2384. Don't collect thread stacks when running under debugger ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9835/1/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9835/1/src/kudu/util/debug-util.cc@728 PS1, Line 728: if (IsBeingDebugged()) { > TriggerAsync is called for each thread. Even though reading /proc/self/stat Hmm, okay. Could you doc TriggerAsync (or DumpThreadStack, or GetThreadStack) with something like "it's the caller's responsibility to skip this if we're running in a debugger"? -- To view, visit http://gerrit.cloudera.org:8080/9835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib17ffb9514e9b440b8d97843374d2a60913a398b Gerrit-Change-Number: 9835 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 28 Mar 2018 21:38:22 +0000 Gerrit-HasComments: Yes
