Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 )
Change subject: KUDU-2384. Don't collect thread stacks when running under debugger ...................................................................... Patch Set 3: > This is an interesting case. fs_manager-test is failing because > KernelStackWatchdog continues to run in the background after the gflags > destructor runs, and now KernelStackWatchdog calls Env::ReadFileToString > which checks the fault injection string flag, and that string has been > destructed. > > So, it seems the potential fixes are: > (a) make that test case reset fault injection in its destructor > (b) make KernelStackWatchdog avoid using Env calls that are subject to fault > injection > (c) make fault injection short circuit to "not enabled" for /proc reads > (which perhaps is more accurate) > > Thoughts? I'd be in favor of (c). (a) is unintuitive, and can easily happen again in other tests that turn on fault injection. That said, the test in question (TestCreateWithFailedDirs) already resets env_inject_eio to 0 when it finishes; if it didn't, we'd also see a warning that we couldn't clean up the test's temp dir. But I guess here the issue isn't with env_inject_eio, but with env_inject_eio_globs? We don't typically reset that one. -- To view, visit http://gerrit.cloudera.org:8080/9835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib17ffb9514e9b440b8d97843374d2a60913a398b Gerrit-Change-Number: 9835 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 02:19:19 +0000 Gerrit-HasComments: No
