Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9848 )
Change subject: KUDU-2378. Fix unaligned loads of int128 from rows ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9848/1/src/kudu/gutil/port.h File src/kudu/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/9848/1/src/kudu/gutil/port.h@1170 PS1, Line 1170: #if defined(__i386) || defined(ARCH_ATHLON) || defined(__x86_64__) || defined(_ARCH_PPC) Do we actually care about ARCH_ATHLON and _ARCH_PPC? Or was this sourced from somewhere else? http://gerrit.cloudera.org:8080/#/c/9848/1/src/kudu/gutil/port.h@1187 PS1, Line 1187: typename port_internal::enable_if_numeric<T>::type* = nullptr, What does this template parameter do? I don't see 'type' referenced in the function at all. -- To view, visit http://gerrit.cloudera.org:8080/9848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic71149ed5c6881cb16dfe6cf8f7906c044a0b41a Gerrit-Change-Number: 9848 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 28 Mar 2018 23:34:41 +0000 Gerrit-HasComments: Yes
