Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9848 )

Change subject: KUDU-2378. Fix unaligned loads of int128 from rows
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/cfile/plain_block.h
File src/kudu/cfile/plain_block.h:

http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/cfile/plain_block.h@27
PS6, Line 27: #include "kudu/util/coding.h"
> warning: #includes are not sorted properly [llvm-include-order]
looks right to me.


http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/common/partial_row.cc
File src/kudu/common/partial_row.cc:

http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/common/partial_row.cc@191
PS6, Line 191:       // TODO(todd) Is reinterpret_cast unsafe here?
Is this still an open item?


http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/common/partial_row.cc@196
PS6, Line 196:       // TODO(todd) Is reinterpret_cast unsafe here?
Is this still an open item?



--
To view, visit http://gerrit.cloudera.org:8080/9848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic71149ed5c6881cb16dfe6cf8f7906c044a0b41a
Gerrit-Change-Number: 9848
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Tue, 17 Apr 2018 00:47:33 +0000
Gerrit-HasComments: Yes

Reply via email to