Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9848 )
Change subject: KUDU-2378. Fix unaligned loads of int128 from rows ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/gutil/port.h File src/kudu/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/9848/6/src/kudu/gutil/port.h@1222 PS6, Line 1222: memcpy(dst, &src, sizeof(T)); Why additional memcpy() is necessary when USE_REINTERPRET is set? If it's not a typo, please add a comment explaining that. -- To view, visit http://gerrit.cloudera.org:8080/9848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic71149ed5c6881cb16dfe6cf8f7906c044a0b41a Gerrit-Change-Number: 9848 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 17 Apr 2018 01:58:23 +0000 Gerrit-HasComments: Yes
