Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9849 )
Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection ...................................................................... Patch Set 1: (9 comments) These docs will also need to change some in light of Dan's request from the other review that ignoreNull be generalized so it can apply to inserts and updates. http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc File docs/developing.adoc: http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@98 PS1, Line 98: 1.5.0 I'm pretty sure we stopped supporting Spark 1 for 1.6, so we should call that out to explain why 1.5 is the version here. We should also make Spark 2 the default in the docs instead of Spark 1, or even get rid of Spark 1 docs. http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@104 PS1, Line 104: 1.5.0 Spark 2 artifacts are available up to 1.7. http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@114 PS1, Line 114: NB: If using Spark 2, replace all 'sqlContext' to 'spark' in the statements We should "talk Spark 2" by default now. http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162 PS1, Line 162: If unspecified, Remove. http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162 PS1, Line 162: Add "the". http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162 PS1, Line 162: will avoid s Please wrap at 80-100 characters. http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162 PS1, Line 162: Upsert I don't think this needs to be capitalized. http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@166 PS1, Line 166: simpleTableName This variable wasn't defined. http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@176 PS1, Line 176: with nit: s/with/and -- To view, visit http://gerrit.cloudera.org:8080/9849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e Gerrit-Change-Number: 9849 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 29 Mar 2018 08:28:23 +0000 Gerrit-HasComments: Yes
