Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9849 )
Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection ...................................................................... Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc File docs/developing.adoc: http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@98 PS1, Line 98: 1.5.0 > I'm pretty sure we stopped supporting Spark 1 for 1.6, so we should call th Done http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@98 PS1, Line 98: 1.5.0 > +1 for getting rid of Spark1 docs, since we don't ship it anymore. Done http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@104 PS1, Line 104: .5.0 > Spark 2 artifacts are available up to 1.7. Done http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@114 PS1, Line 114: Read a table from Kudu > We should "talk Spark 2" by default now. Done http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162 PS1, Line 162: > Remove. ? http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162 PS1, Line 162: Upsert > I don't think this needs to be capitalized. Done http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162 PS1, Line 162: > Add "the". Done http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@162 PS1, Line 162: > Please wrap at 80-100 characters. Done http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@166 PS1, Line 166: > This variable wasn't defined. Done http://gerrit.cloudera.org:8080/#/c/9849/1/docs/developing.adoc@176 PS1, Line 176: > nit: s/with/and Done -- To view, visit http://gerrit.cloudera.org:8080/9849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e Gerrit-Change-Number: 9849 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 23 Apr 2018 18:42:15 +0000 Gerrit-HasComments: Yes
