Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9849 )
Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Looks good to me, just one minor nit. http://gerrit.cloudera.org:8080/#/c/9849/3/docs/developing.adoc File docs/developing.adoc: http://gerrit.cloudera.org:8080/#/c/9849/3/docs/developing.adoc@116 PS3, Line 116: val df = spark.read.options(Map("kudu.master" -> "kudu.master:7051","kudu.table" -> "kudu_table")).kudu nit: this line is too long. -- To view, visit http://gerrit.cloudera.org:8080/9849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib58bca60360ccd3c3abf579ede8137a34e870b0e Gerrit-Change-Number: 9849 Gerrit-PatchSet: 3 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 25 Apr 2018 18:31:06 +0000 Gerrit-HasComments: Yes
