Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9835 )
Change subject: KUDU-2384. Don't collect thread stacks when running under debugger ...................................................................... KUDU-2384. Don't collect thread stacks when running under debugger This changes the stack watchdog and the 'collect all stacks' utility code to not run when it appears that the process is running under a tracer such as gdb or strace. This makes debugging Kudu processes significantly easier because you don't need to know the magical incantation 'handle SIGUSR2 nostop noprint'. I tested manually by running a master with --diagnostics-log-stack-traces-interval-ms=10 and attaching to it with gdb. With this patch, I didn't see any signals sent. This patch also changes the Env EIO fault injection to never inject failures on /proc/. This is to avoid a TSAN warning since KernelStackWatchdog would otherwise access the env_inject_eio_globs flag concurrent to tests modifying it. Change-Id: Ib17ffb9514e9b440b8d97843374d2a60913a398b Reviewed-on: http://gerrit.cloudera.org:8080/9835 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h M src/kudu/util/env_posix.cc M src/kudu/util/kernel_stack_watchdog.cc M src/kudu/util/os-util.cc M src/kudu/util/os-util.h 6 files changed, 82 insertions(+), 7 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib17ffb9514e9b440b8d97843374d2a60913a398b Gerrit-Change-Number: 9835 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
