Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8313 to look at the new patch set (#5). Change subject: KUDU-2191 (10/n): Hive Metastore notification log event listener ...................................................................... KUDU-2191 (10/n): Hive Metastore notification log event listener This commit adds a notification log event listener to the Hive Metastore integration. The leader master now listens for drop table and alter table events in the HMS, and applies them to the Kudu catalog as necessary. The latest handled notification log event index is recorded in the sys-catalog. Testing: this is a hard component to test, because it is necessarily tied to the catalog manager. I've added tests for specific scenarios in master_hms-itest, however I'm aware that not all codepaths in the listener are covered. master-stress-test now has the HMS integration enabled, since this was the 'missing piece' which allows the catalogs to remain (eventually) consistent in the presence of master crashes. Note on IWYU: this commit continues the trend in this patch series of ignoring files which include HMS or Thrift classes, since the upstream Jenkins instance typically has loads of false positives with these. I have manually verified against a Centos 7 machine that the commit passes IWYU (with the ignores removed). Change-Id: I32ed099c44a593ffe514152135957018f21ed775 --- M build-support/iwyu/iwyu-filter.awk M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_catalog.h M src/kudu/hms/hms_client-test.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/master/CMakeLists.txt M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h A src/kudu/master/hms_notification_log_listener.cc A src/kudu/master/hms_notification_log_listener.h M src/kudu/master/sys_catalog.cc M src/kudu/master/sys_catalog.h 13 files changed, 654 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/8313/5 -- To view, visit http://gerrit.cloudera.org:8080/8313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32ed099c44a593ffe514152135957018f21ed775 Gerrit-Change-Number: 8313 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot