Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8313 )
Change subject: KUDU-2191 (10/n): Hive Metastore notification log event listener ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/8313/6/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/8313/6/src/kudu/integration-tests/master-stress-test.cc@126 PS6, Line 126: opts.extra_master_flags.emplace_back("--hive_metastore_notification_log_poll_period_seconds=1"); > warning: use emplace_back instead of push_back [modernize-use-emplace] Done http://gerrit.cloudera.org:8080/#/c/8313/6/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/8313/6/src/kudu/integration-tests/master_hms-itest.cc@72 PS6, Line 72: opts.extra_master_flags.emplace_back("--hive_metastore_notification_log_poll_period_seconds=1"); > warning: use emplace_back instead of push_back [modernize-use-emplace] Done http://gerrit.cloudera.org:8080/#/c/8313/4/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/8313/4/src/kudu/master/hms_notification_log_listener.cc@125 PS4, Line 125: // Cache the batch size, since it's a runtime flag. > Seems like it would be pretty easy to cache this in the CatalogManager and Done -- To view, visit http://gerrit.cloudera.org:8080/8313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ed099c44a593ffe514152135957018f21ed775 Gerrit-Change-Number: 8313 Gerrit-PatchSet: 7 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 11 Apr 2018 16:45:39 +0000 Gerrit-HasComments: Yes
