Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9452 )
Change subject: KUDU-2293 fix cleanup after failed copies ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/9452/11/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/9452/11/src/kudu/tablet/tablet_metadata.cc@218 PS11, Line 218: // Remove the tablet's data dir group tracked by the DataDirManager. nit: This isn't a very useful comment. Mind adding a comment more along the lines of what I suggested in a comment earlier? http://gerrit.cloudera.org:8080/#/c/9452/11/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/9452/11/src/kudu/tserver/tablet_copy_client.cc@400 PS11, Line 400: state_ = kFinishing; Does the kFinishing state serve any functional purpose? We are already guaranteed, based on the CHECK above, that we were in kStarted state when entering this function, so Abort() will execute its cleanup code either way. -- To view, visit http://gerrit.cloudera.org:8080/9452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0459d484a3064aa2de392328e2910c9f6741be04 Gerrit-Change-Number: 9452 Gerrit-PatchSet: 11 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 11 Apr 2018 01:46:34 +0000 Gerrit-HasComments: Yes
