Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 )
Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@125 PS6, Line 125: case "upsert" => Upsert > In the previous patch, will commented that maybe it's ok to remove InsertIg We allow applications to set the 'kudu.operation'='insert-ignore' option. If we stopped allowing that, it would break existing applications when they upgrade to the new version. It's fine to remove the InsertIgnore type, since it's private, but you'll need to still figure out a way to provide this option. -- To view, visit http://gerrit.cloudera.org:8080/9834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide908ea29f572849eca0ba850ee197c1b22a07c8 Gerrit-Change-Number: 9834 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 12 Apr 2018 19:48:21 +0000 Gerrit-HasComments: Yes
