Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 )
Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@250 PS6, Line 250: more suggested nit: s/more suggested/preferred http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@253 PS6, Line 253: * wo.ignoreDuplicateRowErrors = true Here and below, this can be done more concisely, and I think more clearly, as: insertRows(data, tableName, new KuduWriteOptions(ignoreDuplicateRowErrors = true)) http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@260 PS6, Line 260: @Deprecated() Add a message like @Deprecated("Use KuduContext.insert(.., new KuduWriteOptions(ignoreDuplicateRowErrors = true))") http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@350 PS6, Line 350: throw new IllegalArgumentException(s"Can't set primary key column \'" + key_name + "\' to null") > nit: this line is too long. interpolated strings (s"") don't need to be concatenated, use: s"Can't set primary key column '$key_name' to null" http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala: http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala@23 PS6, Line 23: * KuduWriteOptions holds configuration of writes to Kudu tables. > nit: Can you add a comment about what kind of options it is holding and wha Yeah, I think a quick description on the fields themselves would be good. -- To view, visit http://gerrit.cloudera.org:8080/9834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide908ea29f572849eca0ba850ee197c1b22a07c8 Gerrit-Change-Number: 9834 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 10 Apr 2018 22:01:48 +0000 Gerrit-HasComments: Yes
