Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9834 )

Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull 
option
......................................................................


Patch Set 7:

(8 comments)

Thanks everyone!

http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:

http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@250
PS6, Line 250: preferred:
> nit: s/more suggested/preferred
Done


http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@253
PS6, Line 253:     * }}}
> Here and below, this can be done more concisely, and I think more clearly,
Done


http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@260
PS6, Line 260:                        tableName: String): Unit = {
> Add a message like @Deprecated("Use KuduContext.insert(.., new KuduWriteOpt
Done


http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@350
PS6, Line 350:             if (!writeOptions.ignoreNull) 
operation.getRow.setNull(kuduIdx)
> nit: this line is too long.
Done


http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@350
PS6, Line 350:             if (!writeOptions.ignoreNull) 
operation.getRow.setNull(kuduIdx)
> interpolated strings (s"") don't need to be concatenated, use:
Done


http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala:

http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala@23
PS6, Line 23:   * KuduWriteOptions holds configuration of writes to Kudu tables.
> nit: Can you add a comment about what kind of options it is holding and wha
Done


http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala@23
PS6, Line 23:   * KuduWriteOptions holds configuration of writes to Kudu tables.
> Yeah, I think a quick description on the fields themselves would be good.
Done


http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala:

http://gerrit.cloudera.org:8080/#/c/9834/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala@31
PS6, Line 31: Update exten
> I think it's safe to get rid of this now.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide908ea29f572849eca0ba850ee197c1b22a07c8
Gerrit-Change-Number: 9834
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Apr 2018 00:55:23 +0000
Gerrit-HasComments: Yes

Reply via email to