Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 )
Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10061/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10061/1//COMMIT_MSG@22 PS1, Line 22: listing all : daemons > is this output going to scale to large clusters? eg if you have 200 tablet Mmm I had the same thought which inspired the flag to turn off the flags check. It's a bummer not to see which tablet servers have a flag set. Maybe, if we did something like list the first few tablet servers, and after some threshold abbreviate, e.g. my-tserver-0, my-tserver-1, my-tserver-2, and 86 other tablet servers since users running a lot of tablet servers are most likely using config management software, showing a few addresses might help them figure out why the experimental flag is set. For example, maybe they set an experimental flag on a rack and forgot to remove it from the config group for that rack, and seeing a few hostnames that have rack info encoded in them might help. Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/10061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd6c179e5256b2f2bae2f7486c5e0365ef184706 Gerrit-Change-Number: 10061 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 13 Apr 2018 20:00:38 +0000 Gerrit-HasComments: Yes
