Hello Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10061

to look at the new patch set (#2).

Change subject: [tools] ksck improvements [5/n]: Checks for experimental, 
unsafe, hidden flags
......................................................................

[tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

This adds checks to ksck that look for experimental, unsafe, and hidden
flags set to non-default values on Kudu masters and tablet servers. If
any are found, ksck generates a table summarizing the different flags and
their values. For example:

WARNING: Some masters have hidden, experimental, or unsafe flags set:
          Flag          |        Value        |         Tags         |          
          Master
------------------------+---------------------+----------------------+----------------------------------------------
 codegen_dump_functions | true                | runtime,experimental | 
localhost:7052,localhost:7053
 min_compression_ratio  | 0.80000000000000004 | experimental         | 
localhost:7052,localhost:7051,localhost:7053
 safe_time_max_lag_ms   | 40000               | experimental         | 
localhost:7052
 safe_time_max_lag_ms   | 50000               | experimental         | 
localhost:7053

The table has one row for each unique (flag, value) pair, listing all
daemons with --flag=value. So, in the above output, there are two rows
for the flag --safe_time_max_lag_ms  because it's set to two different
values on two masters. This makes it easy to scan for concerning flags
and their values.

A new flag --check_unusual_flags controls whether flag checks are done.
It default to true. Flag checks may be worth turning off if a cluster
has a large amount of tablet servers with experimental flags, or if a
newer kudu tool is run against a cluster without GetFlags RPC support,
since in these cases the flag check output will be noisy.

Additionally, since the output might not scale to a large number of
servers, the CSV of servers is abbreviated, by default, to 3 entries,
with the number of additional servers indicated. The number of entries
before truncation kicks in is controlled by --truncate_server_csv_length.

Change-Id: Idd6c179e5256b2f2bae2f7486c5e0365ef184706
---
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tools/tool_action_cluster.cc
8 files changed, 346 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/10061/2
--
To view, visit http://gerrit.cloudera.org:8080/10061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd6c179e5256b2f2bae2f7486c5e0365ef184706
Gerrit-Change-Number: 10061
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>

Reply via email to