Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10074 )

Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
What's the motivation? Can you explain in the commit message?


http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@9
PS1, Line 9: protobug
protobuf?


http://gerrit.cloudera.org:8080/#/c/10074/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/10074/1/build-support/jenkins/build-and-test.sh@390
PS1, Line 390:      GRADLE_FLAGS="$GRADLE_FLAGS --console=plain --no-daemon 
--no-build-cache"
Why disable the daemon and caching here? Can you add a comment?


http://gerrit.cloudera.org:8080/#/c/10074/1/java/gradle/compile.gradle
File java/gradle/compile.gradle:

http://gerrit.cloudera.org:8080/#/c/10074/1/java/gradle/compile.gradle@26
PS1, Line 26:   options.compilerArgs << '-proc:none' // Ignore leaked 
annotation processors on the compile classpath.
What does that error actually mean? What does "leaking" mean in this context?



--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:16:07 +0000
Gerrit-HasComments: Yes

Reply via email to