Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10074 )

Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> It's hard to measure exactly. Gradle will prevent the rebuild of existing c
I didn't know this was a problem we had; to my untrained eye, the Gradle 
"build" (excluding test runtime) was already quite fast. That's why I asked you 
to quantify it. Two minutes is nothing to sneeze at, but as you showed, 
Gradle's basic incremental building support is good enough to reclaim that time.

So I guess I'm still struggling to qualify whether this trade-off is worth it. 
We're talking about space consumed outside of the build output directory, and 
naive Gradle users won't know how to find that. Even just a few GBs can have an 
impact on a small SSD. At least ccache is opt-in so you have to be aware of it 
in order to make its space/time trade-off.



--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 19:21:38 +0000
Gerrit-HasComments: Yes

Reply via email to