Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 )
Change subject: KUDU-2351 Add IP/port for Recv() failure ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/9818/14/src/kudu/security/tls_socket-test.cc File src/kudu/security/tls_socket-test.cc: http://gerrit.cloudera.org:8080/#/c/9818/14/src/kudu/security/tls_socket-test.cc@224 PS14, Line 224: server.Stop(); > I'm surprised this works, how does the server receive and respond to the wr the while loop that starts in L157 starts with BlockingRecv, so by the time I call server.Stop() here it's already receiving. That's why I need to write and receive first, before I can attempt the BlockingRecv that fails due to the socket being closed. http://gerrit.cloudera.org:8080/#/c/9818/14/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/9818/14/src/kudu/util/net/socket-test.cc@65 PS14, Line 65: > Could this thread be a local variable, and join at the end of the test? I Done -- To view, visit http://gerrit.cloudera.org:8080/9818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22436b13bb351b132e1c0b7159294dd0c980c2b3 Gerrit-Change-Number: 9818 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 17:13:27 +0000 Gerrit-HasComments: Yes
