Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 )
Change subject: KUDU-2351 Add IP/port for Recv() failure ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/9818/11/src/kudu/security/tls_socket-test.cc File src/kudu/security/tls_socket-test.cc: http://gerrit.cloudera.org:8080/#/c/9818/11/src/kudu/security/tls_socket-test.cc@231 PS11, Line 231: ASSERT_OK(client_sock->BlockingRecv(buf.get(), kEchoChunkSize, &nread, > Can you add some explanation for why this requires a background thread? Se makes sense, thanks http://gerrit.cloudera.org:8080/#/c/9818/11/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: http://gerrit.cloudera.org:8080/#/c/9818/11/src/kudu/security/tls_socket.cc@111 PS11, Line 111: errno = 0; > This is a really hot function, so the overhead of creating this message (al thanks, moved it down under L118, so the save_errno != 0 case in L125 could use it as well without duplication. All cases except for one are cases where this is used, so I think it shouldn't have an impact, but let me know if I should still use lazy evaluation instead. http://gerrit.cloudera.org:8080/#/c/9818/11/src/kudu/security/tls_socket.cc@125 PS11, Line 125: > probably worth prefixing this with the message as well. Done http://gerrit.cloudera.org:8080/#/c/9818/11/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/9818/11/src/kudu/util/net/socket-test.cc@68 PS11, Line 68: Socket sock; > Could this preamble be done in the main thread? Then you wouldn't need to Done -- To view, visit http://gerrit.cloudera.org:8080/9818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22436b13bb351b132e1c0b7159294dd0c980c2b3 Gerrit-Change-Number: 9818 Gerrit-PatchSet: 12 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 09:50:50 +0000 Gerrit-HasComments: Yes
