Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 )
Change subject: KUDU-2351 Add IP/port for Recv() failure ...................................................................... Patch Set 15: > Patch Set 15: > > Failures look like they may be legit. TestRecvFailure is definitely my bad, it seems like a race condition due to the socket in server.Start() not yet listening/set up properly. I introduced a 100ms sleep which should take care of it. I can wait for a promise if that approach is better, but that seems a bit of an overkill now. I added slice based on IWYU too, however that doesn't seem to be related to my change, but it seems persistent on wanting it. TabletCopyITest.TestBeginTabletCopySessionConcurrency seems random flake, it worked fine on my machine. -- To view, visit http://gerrit.cloudera.org:8080/9818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22436b13bb351b132e1c0b7159294dd0c980c2b3 Gerrit-Change-Number: 9818 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 18:12:44 +0000 Gerrit-HasComments: No
