Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10152 )
Change subject: Support running full Gradle builds in build-and-test.sh ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10152/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/10152/2/build-support/jenkins/build-and-test.sh@56 PS2, Line 56: # BUILD_JAVA Default: 1 : # Build and test java code if this is set to 1. Why keep this around? Aren't BUILD_MAVEN and BUILD_GRADLE sufficiently expressive? http://gerrit.cloudera.org:8080/#/c/10152/2/build-support/jenkins/build-and-test.sh@114 PS2, Line 114: BUILD_JAVA=${BUILD_JAVA:-1} Shouldn't BUILD_MAVEN be listed here? And in a few other places that manipulate all the BUILD_FOO variables? -- To view, visit http://gerrit.cloudera.org:8080/10152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27a1bd330227d735f2139ceb420947528363f81c Gerrit-Change-Number: 10152 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Apr 2018 19:29:27 +0000 Gerrit-HasComments: Yes
