Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10152 )
Change subject: Support running full Gradle builds in build-and-test.sh ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10152/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/10152/2/build-support/jenkins/build-and-test.sh@56 PS2, Line 56: # BUILD_JAVA Default: 1 : # Build and test java code if this is set to 1. > Because I expect that this is what will remain when maven is removed. BUILD So is your expectation that when Maven is removed, BUILD_MAVEN is also removed but BUILD_JAVA and BUILD_GRADLE remain? If so, at that point BUILD_JAVA and BUILD_GRADLE are synonymous with one another. Or, if you expect both BUILD_MAVEN and BUILD_GRADLE to disappear when Maven is removed, that seems unnecessarily churny. I think it'd be fine to 1) switch from a singular BUILD_JAVA to the two-switch BUILD_MAVEN/BUILD_GRADLE approach now, and 2) remove BUILD_MAVEN (but keep BUILD_GRADLE) when removing Maven. -- To view, visit http://gerrit.cloudera.org:8080/10152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27a1bd330227d735f2139ceb420947528363f81c Gerrit-Change-Number: 10152 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Apr 2018 19:58:30 +0000 Gerrit-HasComments: Yes
