Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10152 )
Change subject: Support running full Gradle builds in build-and-test.sh ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10152/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/10152/2/build-support/jenkins/build-and-test.sh@56 PS2, Line 56: # BUILD_JAVA Default: 1 : # Build and test java code if this is set to 1. > So is your expectation that when Maven is removed, BUILD_MAVEN is also remo Yes after this migration both BUILD_GRADLE and BUILD_MAVEN would be removed. My thought is that anyone who is using these flags (not sure who is but being conscious of compatibility) may not care about the build system but just that java is being built. I don't want to break any cases that are setting BUILD_JAVA today. And I especially don't want to break it twice. For anyone who want's a java build just set BUILD_JAVA to what you need and things will always work, for those who care about the build system throughout this transition there are lower level flags for compatibility. -- To view, visit http://gerrit.cloudera.org:8080/10152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27a1bd330227d735f2139ceb420947528363f81c Gerrit-Change-Number: 10152 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 23 Apr 2018 20:05:24 +0000 Gerrit-HasComments: Yes
