Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9732 )
Change subject: striped64: reduce size from 192 to 16 bytes ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9732/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9732/2//COMMIT_MSG@16 PS2, Line 16: - previously it used a virtual destructor, which required a vtbl to be : stored. This is a best practice but in this case we always delete : particular subclasses and don't hold on to references using the : superclass, so I think it's worth bending the rules a bit. > Could you document this rule bending somewhere so that users of Striped64 a Done http://gerrit.cloudera.org:8080/#/c/9732/2/src/kudu/util/striped64.h File src/kudu/util/striped64.h: http://gerrit.cloudera.org:8080/#/c/9732/2/src/kudu/util/striped64.h@43 PS2, Line 43: AtomicInt<int64_t> value_; > Replace this with std::atomic<int64_t>, for consistency? Done http://gerrit.cloudera.org:8080/#/c/9732/2/src/kudu/util/striped64.h@141 PS2, Line 141: class LongAdder : Striped64 { > What do you think about simplifying further and removing the distinction be not a bad idea but didn't want to burn another hour on this so just did the smaller items from the review. -- To view, visit http://gerrit.cloudera.org:8080/9732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9ba955357744935ac6242cd3b609412c7e9da66 Gerrit-Change-Number: 9732 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 21:35:22 +0000 Gerrit-HasComments: Yes
