Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9732 )
Change subject: striped64: reduce size from 192 to 16 bytes ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9732/3/src/kudu/util/striped64.cc File src/kudu/util/striped64.cc: http://gerrit.cloudera.org:8080/#/c/9732/3/src/kudu/util/striped64.cc@161 PS3, Line 161: const int64_t old = cell->value_.load(std::memory_order_relaxed); > cuz the default argument for Load() is kMemOrderNoBarrier which is the same oh, I see, I inconsistently converted them. Will fix. -- To view, visit http://gerrit.cloudera.org:8080/9732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9ba955357744935ac6242cd3b609412c7e9da66 Gerrit-Change-Number: 9732 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 22:00:31 +0000 Gerrit-HasComments: Yes
