Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/2711 )
Change subject: KUDU-2414. Scanner should not retry a SCANNER_EXPIRED error without reopening ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2711/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/2711/2/src/kudu/client/client-test.cc@1487 PS2, Line 1487: ASSERT_OK(scanner.SetTimeoutMillis(30 * 1000)); > Will this be long enough in ASAN/TSAN environments? it should. It responds basically instantly in a non-TSAN. -- To view, visit http://gerrit.cloudera.org:8080/2711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e09849d5b749db958c3a3df89fd8de9947ab991 Gerrit-Change-Number: 2711 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 24 Apr 2018 00:55:39 +0000 Gerrit-HasComments: Yes
