Todd Lipcon has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/2711 )
Change subject: KUDU-2414. Scanner should not retry a SCANNER_EXPIRED error
without reopening
......................................................................
KUDU-2414. Scanner should not retry a SCANNER_EXPIRED error without reopening
This fixes yet another tight retry loop seen while testing Impala. A scanner
expired on the server side, and the client got the expiration error. However,
the current code sees that as retryable, but should know that it's the kind
of retry that must re-open the scanner.
Without the fix, the new unit test fails with:
../../src/kudu/client/client-test.cc:1504: Failure
Expected: "Not found: Scanner not found"
To be equal to: s.ToString()
Which is: "Timed out: Scan RPC to 127.110.140.1:33568 timed out after
0.000s (SENT): Not found: Scanner not found"
../../src/kudu/client/client-test.cc:1508: Failure
Expected: 1
To be equal to: scan_rpcs->TotalCount()
Which is: 104127
Change-Id: I5e09849d5b749db958c3a3df89fd8de9947ab991
Reviewed-on: http://gerrit.cloudera.org:8080/2711
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <[email protected]>
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
4 files changed, 67 insertions(+), 9 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/2711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e09849d5b749db958c3a3df89fd8de9947ab991
Gerrit-Change-Number: 2711
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
