Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10202
to review the following change.
Change subject: java: fix remainder of error-prone issues
......................................................................
java: fix remainder of error-prone issues
- Suppress a few false positives where we are doing something sketchy
but know it to be OK
- Fix two cases where a class member shadowed a member of a superclass
- Avoid StringBuffer in timestampToString. StringBuffer is synchronized,
so it is probably more efficient to use plain String concatenation
instead.[1]
- Avoid reference-equality checks in Status.fromMasterErrorPB and
Status.fromTabletServerErrorPB. Based on the call sites I believe
these checks would never have fired, because we only call these
methods in cases where we know there to have been an actual error.
- Fix construction of the Flume KuduOperationProducer implementation to
properly throw exceptions by using
clazz.getDeclaredConstructor().newInstance() instead of
clazz.newInstance()[2]
[1]
https://github.com/google/error-prone/blob/master/docs/bugpattern/JdkObsolete.md
[2]
https://github.com/google/error-prone/blob/master/docs/bugpattern/ClassNewInstance.md
Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/IsAlterTableDoneRequest.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/IsCreateTableDoneRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
11 files changed, 27 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/10202/1
--
To view, visit http://gerrit.cloudera.org:8080/10202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d
Gerrit-Change-Number: 10202
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
