Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10202 )
Change subject: java: fix remainder of error-prone issues ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10202/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10202/1//COMMIT_MSG@15 PS1, Line 15: so it is probably more efficient to use plain String concatenation : instead.[1] > Curious why you didn't use StringBuilder here; that's the recommendation in There's no version of DateFormatter which takes a StringBuilder. So, I had to use the version which returns a String, at which point there isn't really any advantage of creating a stringbuilder just to concat two strings. -- To view, visit http://gerrit.cloudera.org:8080/10202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54f67c9718e1022d7996ab1cb827f68c1beb5d3d Gerrit-Change-Number: 10202 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Apr 2018 22:04:35 +0000 Gerrit-HasComments: Yes
