Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 )
Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7362/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: http://gerrit.cloudera.org:8080/#/c/7362/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java@241 PS5, Line 241: so we shouldn't unregister it. > maybe mention the pitfalls of unregistering it? (i.e. why we care about thi well, it will crash due to the assertion I just added. I thought the level of detail here was OK since it doesn't make sense to unregister something that wasn't registered http://gerrit.cloudera.org:8080/#/c/7362/5/java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java File java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java: http://gerrit.cloudera.org:8080/#/c/7362/5/java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java@85 PS5, Line 85: assert(removed) : "Could not remove seqid " + sequenceId + " from request tracker"; > do we ever compile with -ea ? i forget yea, our tests run with -ea (while I was working on this I caused test failures due to not handling the corner case of NO_SEQ_NO) -- To view, visit http://gerrit.cloudera.org:8080/7362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4a977f36b9c7ba3758322a2216ce90208b5d014 Gerrit-Change-Number: 7362 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward #314 Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 26 Apr 2018 22:17:47 +0000 Gerrit-HasComments: Yes
