Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 )
Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7362/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: http://gerrit.cloudera.org:8080/#/c/7362/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java@241 PS5, Line 241: so we shouldn't unregister it. > my suggestion referred to the fact that this doesn't seem a TODO just a gen oh, I guess the TODO is more what I added elsewhere that it doesn't really make sense for Operation to be a subclass of KuduRpc, since it duplicates a lot of stuff with 'Batch'. I'll reword. -- To view, visit http://gerrit.cloudera.org:8080/7362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4a977f36b9c7ba3758322a2216ce90208b5d014 Gerrit-Change-Number: 7362 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #314 Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 22:31:30 +0000 Gerrit-HasComments: Yes
