Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10201 )
Change subject: java: fix various test style issues ...................................................................... java: fix various test style issues error-prone flagged a number of cases where we were expecting exceptions in tests but not calling 'fail()' in the case that the except was not thrown. This also adds a few suppressions for cases where we are doing odd things with catching exceptions in tests. Change-Id: Ia9a7ce360af3f727e8702109826d7b878f98d6a5 Reviewed-on: http://gerrit.cloudera.org:8080/10201 Reviewed-by: Grant Henke <[email protected]> Tested-by: Kudu Jenkins --- M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestBytes.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java 8 files changed, 30 insertions(+), 23 deletions(-) Approvals: Grant Henke: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia9a7ce360af3f727e8702109826d7b878f98d6a5 Gerrit-Change-Number: 10201 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
