David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 )
Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode ...................................................................... Patch Set 9: (17 comments) http://gerrit.cloudera.org:8080/#/c/9526/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9526/9//COMMIT_MSG@12 PS9, Line 12: validatess typo http://gerrit.cloudera.org:8080/#/c/9526/8/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj: http://gerrit.cloudera.org:8080/#/c/9526/8/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@59 PS8, Line 59: same http://gerrit.cloudera.org:8080/#/c/9526/8/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@59 PS8, Line 59: lude [test]) why doesn't the shorthand used in the imports work ([clojure.core.reducers :as r])? http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj: http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@25 PS9, Line 25: valid, valid: http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@25 PS9, Line 25: follow follows http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@36 PS9, Line 36: invalid, invalid: http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@38 PS9, Line 38: ;; [{:type :invoke, :f :add, :value 1, :process 0} : ;; {:type :ok, :f :add, :value 1, :process 0} : ;; {:type :invoke, :f :add, :value 2, :process 0} : ;; {:type :ok, :f :add, :value 2, :process 0} : ;; {:type :invoke, :f :count, :value nil, :process 0} : ;; {:type :ok, :f :count, :value 2, :process 0} : ;; {:type :invoke, :f :count, :value nil, :process 1} : ;; {:type :ok, :f :count, :value 2, :process 1} : ;; {:type :invoke, :f :add, :value 13, :process 1} : ;: {:type :ok, :f :add, :value 13, :process 1} : ;; {:type :invoke, :f :add, :value 22, :process 0} : ;; {:type :ok, :f :add, :value 22, :process 0} : ;; {:type :invoke, :f :count, :value nil, :process 0} : ;; {:type :ok, :f :count, :value 2, :process 0} : ;; {:type :invoke, :f :add, :value 250, :process 1} : ;; {:type :ok, :f :add, :value 250, :process 1}] : ;; why? what's the anomaly that the checker is flagging? http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@72 PS9, Line 72: ;; The invocation operation examples: : ;; [{:process 0, :type :invoke, :f :count, :value nil} : ;; {:process 1, :type :invoke, :f :add, :value 3} : ;; {:process 1, :type :info, :f :add, :value 3} : ;; {:process 0, :type :ok, :f :count, :value 0}] Since you're talking about valid and invalid histories before this doesn't add much http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@77 PS9, Line 77: (defn add-op [] (->> (range) docs: "The add operation to be performed by the processes" http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@82 PS9, Line 82: (defn count-op [] {:type :invoke, :f :count, :value nil}) docs: "The count operation to be performed by the processes" http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@85 PS9, Line 85: or you mean "and" right? http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@86 PS9, Line 86: or same http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@101 PS9, Line 101: n that: operations, making sure that: http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@103 PS9, Line 103: successfully sucessful http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@104 PS9, Line 104: o goes http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@163 PS9, Line 163: the table rows of the table http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@191 PS9, Line 191: count counts -- To view, visit http://gerrit.cloudera.org:8080/9526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d5c0e3b91af58576eb6cd408d922ec7c0fef6c Gerrit-Change-Number: 9526 Gerrit-PatchSet: 9 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 07 May 2018 19:37:36 +0000 Gerrit-HasComments: Yes
