Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 )
Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode ...................................................................... Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/9526/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9526/9//COMMIT_MSG@10 PS9, Line 10: unique value > unique values? Yeah, that's right. http://gerrit.cloudera.org:8080/#/c/9526/9//COMMIT_MSG@12 PS9, Line 12: , > : Done http://gerrit.cloudera.org:8080/#/c/9526/9//COMMIT_MSG@12 PS9, Line 12: validatess > typo Done http://gerrit.cloudera.org:8080/#/c/9526/9//COMMIT_MSG@12 PS9, Line 12: 'count', 'add' > It would be nice to describe what 'count' and 'add' mean, in essence. Done http://gerrit.cloudera.org:8080/#/c/9526/9//COMMIT_MSG@13 PS9, Line 13: than or equal to the : count of previous writes by the same client, and the row count never go : down from the previous reads > Is there any other mode in which that constraint would be broken? If the client uses READ_LATEST on a non-leader replica, this could be broken. http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj: http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@38 PS9, Line 38: ;; [{:type :invoke, :f :add, :value 1, :process 0} : ;; {:type :ok, :f :add, :value 1, :process 0} : ;; {:type :invoke, :f :add, :value 2, :process 0} : ;; {:type :ok, :f :add, :value 2, :process 0} : ;; {:type :invoke, :f :count, :value nil, :process 0} : ;; {:type :ok, :f :count, :value 2, :process 0} : ;; {:type :invoke, :f :count, :value nil, :process 1} : ;; {:type :ok, :f :count, :value 2, :process 1} : ;; {:type :invoke, :f :add, :value 13, :process 1} : ;: {:type :ok, :f :add, :value 13, :process 1} : ;; {:type :invoke, :f :add, :value 22, :process 0} : ;; {:type :ok, :f :add, :value 22, :process 0} : ;; {:type :invoke, :f :count, :value nil, :process 0} : ;; {:type :ok, :f :count, :value 2, :process 0} : ;; {:type :invoke, :f :add, :value 250, :process 1} : ;; {:type :ok, :f :add, :value 250, :process 1}] : ;; > Yep, I agree with David: it would be nice to describe the problem in the ou Right, the expected count output should be 3. Updated it in the latest version. http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@198 PS9, Line 198: > Is there a mode that, if specified, will make this test fail at all? Yeah, using READ_LATEST should fail the test. http://gerrit.cloudera.org:8080/#/c/9526/9/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@203 PS9, Line 203: > values Done -- To view, visit http://gerrit.cloudera.org:8080/9526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d5c0e3b91af58576eb6cd408d922ec7c0fef6c Gerrit-Change-Number: 9526 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 09 May 2018 01:24:10 +0000 Gerrit-HasComments: Yes
