Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 )
Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths ...................................................................... Patch Set 2: (4 comments) I think it's worth adding test for this new piece of functionality. Maybe, just add one into the set of tests in webserver-test.cc? Also, how does it work the already existing compression for the end-point like /tracing/json/end_recording_compresse ? Does it do double-compression in that case? http://gerrit.cloudera.org:8080/#/c/10332/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10332/2//COMMIT_MSG@9 PS2, Line 9: browser nit: client It might be not a browser, but just some tool. http://gerrit.cloudera.org:8080/#/c/10332/2//COMMIT_MSG@10 PS2, Line 10: and when the user is not using curl What's wrong with curl in that perspective? http://gerrit.cloudera.org:8080/#/c/10332/2/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/10332/2/src/kudu/server/webserver.cc@481 PS2, Line 481: allowed nit: accepted by the caller ? http://gerrit.cloudera.org:8080/#/c/10332/2/src/kudu/server/webserver.cc@495 PS2, Line 495: Substitute("Content-Encoding: $0\r\n", "gzip"); why not just "Content-Encoding: gzip\r\n" ? -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 07 May 2018 22:55:18 +0000 Gerrit-HasComments: Yes
