Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 )
Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths ...................................................................... Patch Set 4: (4 comments) There seems to be no double-compression? So I called "http://localhost:8051/tracing/json/end_recording_compressed";, and then got a gz file, after I decompressed it, it showed a content that makes sense. Thanks! http://gerrit.cloudera.org:8080/#/c/10332/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10332/2//COMMIT_MSG@9 PS2, Line 9: gzip co > nit: client Done http://gerrit.cloudera.org:8080/#/c/10332/2//COMMIT_MSG@10 PS2, Line 10: caller. > What's wrong with curl in that perspective? My fault. Cuz a plain curl usually doesn't specify Accept-Encoding. I've changed the commit msg. http://gerrit.cloudera.org:8080/#/c/10332/2/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/10332/2/src/kudu/server/webserver.cc@481 PS2, Line 481: accepte > nit: accepted by the caller ? Done http://gerrit.cloudera.org:8080/#/c/10332/2/src/kudu/server/webserver.cc@495 PS2, Line 495: "Content-Encoding: gzip\r\n"; > why not just Done -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 4 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 10 May 2018 22:52:42 +0000 Gerrit-HasComments: Yes
