Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 )
Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths ...................................................................... Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/10332/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10332/6//COMMIT_MSG@9 PS6, Line 9: the nit: Extra "the". http://gerrit.cloudera.org:8080/#/c/10332/6//COMMIT_MSG@10 PS6, Line 10: caller nit: I think the http terminology is "client" or "requestor". http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc@160 PS6, Line 160: gzip, deflate, br Because I'm paranoid, could you put gzip second or later in the list, to test the server skips encodings the server doesn't support. http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc@175 PS6, Line 175: megaturbogzip :) http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc@183 PS6, Line 183: "HTTP/1.1 200 OK" This is the status line; not a header. Also, neither this nor headers will be compressed, so I expect this test would succeed regardless of compression. http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc@195 PS6, Line 195: compressions nit: Extra 's'. http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver.cc@61 PS6, Line 61: struct sockaddr_in; > warning: invalid case style for class 'sockaddr_in' [readability-identifier You can ignore this one. http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver.cc@485 PS6, Line 485: stringstream ss(accept_encoding_str); We have gutil functions to make this easier. Check out - StripWhiteSpace in gutill/strings/strip.h - Split in gutil/strings/split.h -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 14 May 2018 23:07:11 +0000 Gerrit-HasComments: Yes
