Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 )
Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode ...................................................................... Patch Set 13: (8 comments) http://gerrit.cloudera.org:8080/#/c/9526/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9526/12//COMMIT_MSG@12 PS12, Line 12: c > Actually, I meant to replace comma with the column, i.e. update this like Done http://gerrit.cloudera.org:8080/#/c/9526/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj: http://gerrit.cloudera.org:8080/#/c/9526/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@67 PS12, Line 67: [clojure.core.reducers :as r] > Is this used in this file at all? Yeah, in L 87 and below. http://gerrit.cloudera.org:8080/#/c/9526/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@68 PS12, Line 68: [knossos.op :as op]) > Is this used in this file at all? Done http://gerrit.cloudera.org:8080/#/c/9526/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@72 PS12, Line 72: "The add operation to be performed by the processes." > Maybe, make it Clojure-style documentation? Done http://gerrit.cloudera.org:8080/#/c/9526/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@79 PS12, Line 79: (defn count-op [] > Ditto Done http://gerrit.cloudera.org:8080/#/c/9526/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@82 PS12, Line 82: > BTW, what happens if a write operation fails? Does the test signal an asse Yeah, similar to register model, if a write operation fails, it will not signal an assertion failure as that does not directly indicate a consistency anomaly. http://gerrit.cloudera.org:8080/#/c/9526/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@87 PS12, Line 87: > Why not just 'op'? The require directive above introduced op for knossos.o Done http://gerrit.cloudera.org:8080/#/c/9526/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/sets.clj@92 PS12, Line 92: > ditto Done -- To view, visit http://gerrit.cloudera.org:8080/9526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d5c0e3b91af58576eb6cd408d922ec7c0fef6c Gerrit-Change-Number: 9526 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 09 May 2018 23:10:25 +0000 Gerrit-HasComments: Yes
