Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs ...................................................................... Patch Set 2: (2 comments) > Patch Set 2: > > > Patch Set 2: > > > > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ? > > probably less relevant than the original patch set, but I believe it could > still fail, at least I managed to get this failure even without the > check_openssl in preflight before adding PKG_CONFIG_PATH to my .bash_profile. > I'm not completely sure how that happened though. FWIW I haven't had to set PKG_CONFIG_PATH to get the build to work http://gerrit.cloudera.org:8080/#/c/10356/2/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/10356/2/docs/installation.adoc@615 PS2, Line 615: libraris nit: libraries http://gerrit.cloudera.org:8080/#/c/10356/2/docs/installation.adoc@617 PS2, Line 617: /usr/local surround with back ticks -- To view, visit http://gerrit.cloudera.org:8080/10356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794 Gerrit-Change-Number: 10356 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 10 May 2018 18:21:11 +0000 Gerrit-HasComments: Yes