Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs ...................................................................... Patch Set 2: > > Patch Set 2: > > > > > > Patch Set 2: > > > > > > > > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c > ? > > > > > > probably less relevant than the original patch set, but I > believe > > > it could still fail, at least I managed to get this failure > even > > > without the check_openssl in preflight before adding > > > PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure > how > > > that happened though. > > > > If you use preflight and your openssl instaled via HomeBrew, then > I would expect it to fail regardless of PKG_CONFIG_PATH in > .bash_profile b prior 60c8e30 changelist. > > > > However, I don't think this is relevant after 60c8e30. I would > prefer to keep less details in the docs if the things are already > automated. > > +1. The dupes removal is still relevant. Yep, I also think it's worth removing homebrew/dupes; that makes sense. -- To view, visit http://gerrit.cloudera.org:8080/10356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794 Gerrit-Change-Number: 10356 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 10 May 2018 20:00:54 +0000 Gerrit-HasComments: No
