Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs ...................................................................... Patch Set 2: > Patch Set 2: > > > Patch Set 2: > > > > > > Patch Set 2: > > > > > > > > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ? > > > > > > probably less relevant than the original patch set, but I believe > > > it could still fail, at least I managed to get this failure even > > > without the check_openssl in preflight before adding > > > PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure how > > > that happened though. > > > > If you use preflight and your openssl instaled via HomeBrew, then I would > > expect it to fail regardless of PKG_CONFIG_PATH in .bash_profile b prior > > 60c8e30 changelist. > > > > However, I don't think this is relevant after 60c8e30. I would prefer to > > keep less details in the docs if the things are already automated. > > I ran into this first when I was trying to build 1.7.1-RC1 which is before > check_openssl() was added to preflight, so I thought it could still fail. > > Upon further inspection I can see why it failed on 1.7.1-RC1, diff > 1.7.1-RC1..HEAD reveals this change in build-thirdparty.sh: > > - OPENSSL_CFLAGS=$(pkg-config --cflags openssl) > - if [ -z $OPENSSL_CFLAGS ]; then > + if ! OPENSSL_CFLAGS=$(pkg-config --cflags openssl); then > > This pretty much rules out running into this on since 9f6b7f1682, so people > can run into this only if building older branches. > > I'll remove this warning from the patch and backport KUDU-2346 (9f6b7f1682) > to 1.7.x. Should I backport it to any other branches? sorry, didn't check the formatting before posting, this is the actual diff: - OPENSSL_CFLAGS=$(pkg-config --cflags openssl) - if [ -z $OPENSSL_CFLAGS ]; then + if ! OPENSSL_CFLAGS=$(pkg-config --cflags openssl); then -- To view, visit http://gerrit.cloudera.org:8080/10356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794 Gerrit-Change-Number: 10356 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 11 May 2018 16:15:12 +0000 Gerrit-HasComments: No
